Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: initialize EME for all playlists and PSSH values #872

Merged
merged 2 commits into from
Jul 7, 2020
Merged

fix: initialize EME for all playlists and PSSH values #872

merged 2 commits into from
Jul 7, 2020

Conversation

gesinger
Copy link
Contributor

@gesinger gesinger commented Jun 19, 2020 •
edited
Loading

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

brandonocasey
brandonocasey previously approved these changes Jun 19, 2020
View reviewed changes
@gkatsev gkatsev changed the base branch from master to main June 19, 2020 16:51
@gkatsev gkatsev dismissed brandonocasey’s stale review June 19, 2020 16:51

The base branch was changed.

@gkatsev gkatsev added this to the 2.1 milestone Jul 6, 2020
@gesinger gesinger force-pushed the fix/multiple-pssh-initialize branch from b9fe836 to 7fe5690 Compare July 6, 2020 19:51
gkatsev
gkatsev reviewed Jul 7, 2020
View reviewed changes
Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had one question, LGTM otherwise.

src/videojs-http-streaming.js Show resolved Hide resolved
gkatsev
gkatsev approved these changes Jul 7, 2020
View reviewed changes
src/videojs-http-streaming.js Show resolved Hide resolved
@gesinger gesinger merged commit e0e497f into videojs:main Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonocasey brandonocasey brandonocasey approved these changes

@gkatsev gkatsev gkatsev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@gesinger @gkatsev @brandonocasey